Refactor chainstore and related components #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
austinabell
force-pushed
the
austin/csrefactor
branch
from
1746ebb
to
b6aa2b3
Compare
dutterbutter
approved these changes
Nov 9, 2020
Comment on lines
+309
to
+312
| // TODO get tipset by height using cache instead of reloading tipsets | ||
| let mut ts_temp: Option<Tipset> = None; | ||
| loop { | ||
| let pts = if let Some(temp) = &ts_temp { |
There was a problem hiding this comment.
Could you use the tip_index.rs here to act as the cache? If not what ts cache would that be?
There was a problem hiding this comment.
tip index is really broken right now and I'd rather not add any more usages until #814 is done. (I didn't change this code, just was moved)
timvermeulen
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
StateManagerorChainStore, which was leading to incorrect behaviour in some cases, and also this allows us to build caching for these things to avoid unnecessary workThere should be no functional change from this, aside from fixing the incorrect behaviour that existed
Reference issue to close (if applicable)
Closes
Other information and links