Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup batch_verify_seal and tipset state execution #807

Merged
merged 6 commits into from
Nov 7, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Cleaned up types and removed TODO for Switch batch verify seals to use async tasks instead of threads #676 since Rayon will be our best bet here
    • Looked pretty in depth with this, and handling manually or with an async alternative is not as performant or just unnecessarily unergonomic with no benefit in practice
  • Wrapped state execution in a spawn_blocking to avoid starving the runtime executor
    • I want to do a larger refactor later of the state manager/cs to follow a similar pattern for the function signatures (&Arc<Self> when the function can possibly spawn a new thread which uses self and &self otherwise, which has no implications outside of this aside from maybe tests and allows us to use and implement caching and other logic on top of them)

Reference issue to close (if applicable)

Closes #676

Other information and links

@austinabell austinabell merged commit 7990d4d into main Nov 7, 2020
@austinabell austinabell deleted the austin/bvs branch November 7, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch batch verify seals to use async tasks instead of threads
3 participants