-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conformance vectors #768
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
October 19, 2020 19:11
austinabell
added
Interop
Interop with Lotus/specs-actors and testing
Status: Needs Review
labels
Oct 19, 2020
ec2
approved these changes
Oct 20, 2020
gas: Rc::clone(&gas_tracker), | ||
syscalls, | ||
}; | ||
// let gas_syscalls = GasSyscalls { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
dutterbutter
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
GasSyscalls
andDefaultSyscalls
. To match go exactly, we cannot have this wrapper structure and also be memory unsafe, because we need to share the mutable reference (which the runtime does not own)One thing that I didn't change yet was switching the mock verifier to an actual one, for now it isn't important, and relies on params to be fetched to verify, but will do once other diffs are resolved
There are some new cases failing, and I'm not certain it isn't something missed in this upgrade, but I will update this PR if I find it is before this comes in
Reference issue to close (if applicable)
Closes
Other information and links