Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoothing Functions For Actors #594

Merged
merged 18 commits into from
Aug 7, 2020
Merged

Smoothing Functions For Actors #594

merged 18 commits into from
Aug 7, 2020

Conversation

RajarupanSampanthan
Copy link
Contributor

@RajarupanSampanthan RajarupanSampanthan commented Aug 2, 2020 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Adds packages forest_math and forest_smooth under the utils/ directory
  • Adds structs FilterEstimate and AlphaBetaFilter
  • Adds tests

Reference issue to close (if applicable)

Closes
#594

Other information and links

austinabell
austinabell suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick scan, I'll review the details of the logic tomorrow morning :) Looks good though

utils/math/Cargo.toml Outdated Show resolved Hide resolved
utils/math/src/lib.rs Outdated Show resolved Hide resolved
utils/math/src/lib.rs Outdated Show resolved Hide resolved
utils/smoothing/Cargo.toml Outdated Show resolved Hide resolved
utils/math/src/lib.rs Outdated Show resolved Hide resolved
utils/math/src/lib.rs Outdated Show resolved Hide resolved
utils/smoothing/src/alpha_beta_filter.rs Outdated Show resolved Hide resolved
utils/smoothing/src/constants.rs Outdated Show resolved Hide resolved
RajarupanSampanthan and others added 4 commits August 4, 2020 09:18
@RajarupanSampanthan @austinabell
Update utils/math/src/lib.rs
9b15b8a 
Co-authored-by: Austin Abell <austinabell8@gmail.com>
@RajarupanSampanthan @austinabell
Update utils/math/src/lib.rs
bb0cbaf 
Co-authored-by: Austin Abell <austinabell8@gmail.com>
@RajarupanSampanthan @austinabell
Update utils/smoothing/Cargo.toml
3b3592d 
Co-authored-by: Austin Abell <austinabell8@gmail.com>
@RajarupanSampanthan
Adding some requested changes
d14b2db
@ec2
Copy link
Member

ec2 commented Aug 5, 2020

I dont think you needed to create 2 new crates for these. Can just throw them into vm/actor/src/util. I don't think these will be used anywhere else.

austinabell
austinabell suggested changes Aug 7, 2020
View reviewed changes
vm/actor/src/util/alpha_beta_filter.rs Outdated Show resolved Hide resolved
vm/actor/src/util/alpha_beta_filter.rs Outdated Show resolved Hide resolved
vm/actor/src/util/math.rs Outdated Show resolved Hide resolved
vm/actor/src/util/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/util/smooth.rs Outdated Show resolved Hide resolved
vm/actor/src/util/smooth.rs Outdated Show resolved Hide resolved
vm/actor/src/util/smooth.rs Outdated Show resolved Hide resolved
vm/actor/src/util/smooth.rs Outdated Show resolved Hide resolved
vm/actor/src/util/alpha_beta_filter.rs Outdated Show resolved Hide resolved
vm/actor/src/util/alpha_beta_filter.rs Outdated Show resolved Hide resolved
@RajarupanSampanthan RajarupanSampanthan merged commit 9c8e9a6 into main Aug 7, 2020
@RajarupanSampanthan RajarupanSampanthan deleted the rupan/smooth branch August 7, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@timvermeulen timvermeulen Awaiting requested review from timvermeulen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RajarupanSampanthan @ec2 @austinabell