Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gc): refresh current_tipset together with current_epoch after sleeping #5122

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jan 9, 2025

Summary of changes

This PR fixes a potential bug in GC flow that after sleeping(10h), only current_epoch is refreshed but the 10h old tipset is used for the filtering step.

It also refactors a few chain traversal APIs to be more generic in preparation for lite GC implementation that is tracked by #5121

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 changed the title fix(gc): refresh current_tipset together with current_epoch after… fix(gc): refresh current_tipset together with current_epoch after sleeping Jan 9, 2025
@hanabi1224 hanabi1224 marked this pull request as ready for review January 9, 2025 10:33
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 9, 2025 10:33
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and elmattic and removed request for a team January 9, 2025 10:33
@LesnyRumcajs
Copy link
Member

Great! It might be worth mentioning in the changelog.

@hanabi1224
Copy link
Contributor Author

Great! It might be worth mentioning in the changelog.

@LesnyRumcajs Changelog updated

@elmattic elmattic added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit a253956 Jan 9, 2025
37 checks passed
@elmattic elmattic deleted the hm/gc-refresh-tipset branch January 9, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants