-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ashanti/winning posts #493
Conversation
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
you accidentally committed a file in 821f33b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One thing I would change is having the utils functions take a DB instead of the whole state manager. Looks like (if im correct) that it only relies on the DB from the state manager.... This in turn allows verify_winning_post_proof
to also not have to take in self
, and just DB. This can be done later on if needed though.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #471
Other information and links