Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dockerfile #4786

Merged
merged 5 commits into from
Sep 23, 2024
Merged

fix: Dockerfile #4786

merged 5 commits into from
Sep 23, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Sep 23, 2024

Summary of changes

Previously we use clang-14 in ubuntu:22.04 AS build-env, however golang:1.22-bullseye downgrades it to clang-11 which causes build errors. This PR restores clang version to 14 by upgrading debian to bookworm

Changes introduced in this pull request:

  • fix Dockerfile by explicitly specifying clang version(14)
  • upgrade debian from bullseye to bookworm as clang-14 is not available for bullseye
  • upgrade ubuntu to noble(24.04) to match debian:bookworm
  • retire Dockerfile-alpine
  • retire f3-sidecar/Dockerfile

Manual CI test result:
Waiting for #4784 to land on main
https://github.com/ChainSafe/forest/actions/runs/10997140181/job/30531966771

#19 [slim-image 5/5] RUN forest -V && forest-cli -V && forest-tool -V && forest-wallet -V
#19 0.140 forest-filecoin 0.20.0+git.ac5f0b6
#19 0.167 forest-filecoin 0.20.0+git.ac5f0b6
#19 0.194 forest-filecoin 0.20.0+git.ac5f0b6
#19 0.220 forest-filecoin 0.20.0+git.ac5f0b6
#19 DONE 0.2s

Reference issue to close (if applicable)

Closes #4785

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review September 23, 2024 15:26
@hanabi1224 hanabi1224 requested a review from a team as a code owner September 23, 2024 15:26
@hanabi1224 hanabi1224 requested review from ruseinov and LesnyRumcajs and removed request for a team September 23, 2024 15:26
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone might be relying on the underlying image of Forest, so it might make sense to include the change from 22 to 24 in the changelog. Otherwise, fantastic job!

@hanabi1224
Copy link
Contributor Author

Someone might be relying on the underlying image of Forest, so it might make sense to include the change from 22 to 24 in the changelog. Otherwise, fantastic job!

@LesnyRumcajs changelog added

@hanabi1224 hanabi1224 added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 837d944 Sep 23, 2024
32 checks passed
@hanabi1224 hanabi1224 deleted the hm/fix-Dockerfile branch September 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[automated] Docker check failure
3 participants