Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align with Lotus json format for ActorState #4656

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Aug 20, 2024

Summary of changes

Changes introduced in this pull request:

  • Revert name change in ActorState. I'm not sure if Lotus used Address in the past or if the previous fix was incorrect.

Reference issue to close (if applicable)

Closes #4433

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih changed the title [WIP] fix: align with Lotus json format for ActorState fix: align with Lotus json format for ActorState Aug 22, 2024
@lemmih
Copy link
Contributor Author

lemmih commented Aug 22, 2024

@sudo-shashank You renamed the field here: #4392. Do you remember why?

@lemmih
Copy link
Contributor Author

lemmih commented Aug 22, 2024

@lemmih lemmih marked this pull request as ready for review August 22, 2024 11:51
@lemmih lemmih requested a review from a team as a code owner August 22, 2024 11:51
@lemmih lemmih requested review from ruseinov and sudo-shashank and removed request for a team August 22, 2024 11:51
@lemmih lemmih enabled auto-merge August 22, 2024 12:35
@lemmih lemmih added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 8605030 Aug 22, 2024
49 of 52 checks passed
@lemmih lemmih deleted the lemmih/fix-state-call-rpc branch August 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Filecoin.StateCall test (or implementation)
3 participants