feat: prometheus metrics for RPC methods #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmih
requested review from
LesnyRumcajs and
sudo-shashank
and removed request for
a team
|
@lemmih is it WIP or ready to review? |
lemmih
changed the title
LesnyRumcajs
reviewed
Aug 1, 2024
There was a problem hiding this comment.
rpc_processing_time_count{method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="0.01",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="0.02",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="0.04",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="0.08",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="0.16",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="0.32",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="0.64",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="1.28",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="2.56",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="5.12",method="Filecoin.NodeStatus"} 9
rpc_processing_time_bucket{le="+Inf",method="Filecoin.NodeStatus"} 9
Can we avoid so many records?
We could track just p50, p90 and p99. But we would still have hundreds of metrics. I say we wait and see if the large number of metrics causes any problems / unexpected costs. |
LesnyRumcajs
approved these changes
Aug 2, 2024
sudo-shashank
approved these changes
Aug 2, 2024
qingyunha
reviewed
Aug 29, 2024
| // Histogram with 10 buckets starting from 0.01s going to 5.12s, each bucket twice as big as the last. | ||
| Histogram::new(exponential_buckets(0.01, 2.0, 10)) | ||
| }); | ||
| crate::metrics::default_registry().register( |
There was a problem hiding this comment.
Hi, I'm curious. Is there a particular reason we do not use DEFAULT_REGISTRY.write() here?
There was a problem hiding this comment.
the default_registry() hides the detail that the registry is under an RwLock.
There was a problem hiding this comment.
But, I see that all other metrics use DEFAULT_REGISTRY.write() in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
The new metrics look like this:
Reference issue to close (if applicable)
Closes #3767
Other information and links
Change checklist