-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ashanti/connect state transition #454
Ashanti/connect state transition #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to revert the changes to the submodule you committed
…/chainsafe/forest into ashanti/connect_state_transition
Was there a reason why you removed the concurrent validation of block headers? |
I was going to come back to this in a bit but might as well now, before it was spawning a blocking task which is just synconous (I didn't look too much in detail at the last PR just assumed you guys had verified it) Think it just needs to be changed to (I actually don't know how the |
Yeah they have to be boxed because each future has a different type even though in essence it looks the same. So adding different types is according to the future trait rather than a concrete future type. It looked like it was returning join handles with futures inside of them and using spawn_blocking so in essence didn't see much of a difference between handling them where they are vs handling them at the end where the errors are being collected. Changed to spawn right now |
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
…/chainsafe/forest into ashanti/connect_state_transition
…/chainsafe/forest into ashanti/connect_state_transition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add some comments to the public methods if possible.
Summary of changes
Changes introduced in this pull request:
-a bit of a translation of tipset_state in lotus
-missing a few functions that call tipset_state
-Changes statemanager in sync to an arc readlock due to the need of shared reference in asynchronous context
Reference issue to close (if applicable)
Closes #405
Other information and links