Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block header serialization #450

Merged
merged 5 commits into from
May 27, 2020
Merged

Fix block header serialization #450

merged 5 commits into from
May 27, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented May 26, 2020

Summary of changes
Changes introduced in this pull request:

  • Block header serialization was broken, just didn't get caught before because the genesis and test vector had a null ElectionProof so the inconsistency was not hit. Was found while syncing with new testnet genesis

I also updated the default genesis to this testnet since this should(?) be the same for a while

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 4783502 into master May 27, 2020
@austinabell austinabell deleted the austin/fixheaderser branch May 27, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants