Add CircleCI #441
Merged
Add CircleCI #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priom
reviewed
May 22, 2020
There was a problem hiding this comment.
some of the jobs could benefit from parallelism in circleCI
https://circleci.com/docs/2.0/parallelism-faster-jobs/
|
@priom I agree One thing I've done is actually use a cache on the cargo builds so that we don't need to re-build everything |
GregTheGreek
force-pushed
the
greg/ci/add-circle
branch
from
daba26b
to
043e2cc
Compare
GregTheGreek
force-pushed
the
greg/ci/add-circle
branch
2 times, most recently
from
0b88441
to
432b0a8
Compare
GregTheGreek
force-pushed
the
greg/ci/add-circle
branch
from
432b0a8
to
a131014
Compare
GregTheGreek
force-pushed
the
greg/ci/add-circle
branch
from
b962d8a
to
7af8d92
Compare
GregTheGreek
force-pushed
the
greg/ci/add-circle
branch
from
7af8d92
to
27c9f37
Compare
GregTheGreek
force-pushed
the
greg/ci/add-circle
branch
12 times, most recently
from
4d09e10
to
9e384e2
Compare
ec2
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
ec2
requested review from
StaticallyTypedAnxiety,
flodesi,
RajarupanSampanthan and
timvermeulen
austinabell
approved these changes
Jun 1, 2020
Co-authored-by: Austin Abell <austinabell8@gmail.com>
dutterbutter
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #440
Other information and links
I suggest rolling this out slowly, not making circle builds mandatory yet, let a few prs go through to iron out any potential bugs before migrating.