refactor: migrate MinerGetBaseInfo, StateCall to trait RpcMethod #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatifsyed
requested review from
ruseinov and
elmattic
and removed request for
a team
14 tasks
hanabi1224
reviewed
Apr 19, 2024
|
|
||
| async fn handle( | ||
| ctx: Ctx<impl Blockstore + Send + Sync + 'static>, | ||
| (LotusJson(message), LotusJson(ApiTipsetKey(tsk))): Self::Params, |
There was a problem hiding this comment.
Hope we can get rid of LotusJson wrappers in Params as well
There was a problem hiding this comment.
Hope we can get rid of
LotusJsonwrappers inParamsas well
Yes, exactly what I was thinking. It's quite verbose both here and in api compare tests.
There was a problem hiding this comment.
@aatifsyed I made a draft PR #4247 to drop these wrappers, we can use it for discussion.
ruseinov
reviewed
Apr 19, 2024
| shared_tipset.key().into(), | ||
| ))); | ||
| tests.push(RpcTest::identity( | ||
| StateCall::request((msg.clone().into(), LotusJson(shared_tipset.key().into()))) |
There was a problem hiding this comment.
thought: looking at the verbosity of having to wrap things into LotusJson and struggling with it during my own method impls - I think we could probably try and solve it somehow. I will just leave it here, perhaps we could eventually come up with a good way of solving this.
hanabi1224
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist