Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate node to trait RpcEndpoint #4204

Merged
merged 4 commits into from
Apr 17, 2024
Merged

refactor: migrate node to trait RpcEndpoint #4204

merged 4 commits into from
Apr 17, 2024

Conversation

aatifsyed
Copy link
Contributor

Summary of changes

Blocked on #4203

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@aatifsyed aatifsyed mentioned this pull request Apr 15, 2024
Open
14 tasks
@aatifsyed aatifsyed changed the title refactor: migrate node to trat RpcEndpoint refactor: migrate node to trait RpcEndpoint Apr 15, 2024
@aatifsyed aatifsyed force-pushed the aatifsyed/migrate-sync branch 2 times, most recently from 8de96a4 to 235d055 Compare April 16, 2024 14:07
Base automatically changed from aatifsyed/migrate-sync to main April 16, 2024 18:40
@aatifsyed aatifsyed marked this pull request as ready for review April 17, 2024 08:38
@aatifsyed aatifsyed requested a review from a team as a code owner April 17, 2024 08:38
@aatifsyed aatifsyed requested review from ruseinov and LesnyRumcajs and removed request for a team April 17, 2024 08:38
lemmih
lemmih approved these changes Apr 17, 2024
View reviewed changes
src/cli/subcommands/attach_cmd.rs
// Node API
"node_status" => |()| ApiInfo::node_status_req(),
);
bind_request!(context, api,);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get rid of this line?

@aatifsyed aatifsyed added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 9f57f5d Apr 17, 2024
27 checks passed
@aatifsyed aatifsyed deleted the aatifsyed/migrate-node branch April 17, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aatifsyed @lemmih @LesnyRumcajs