Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): implement Filecoin.ChainTipSetWeight #4192

Merged
merged 6 commits into from
Apr 15, 2024
Merged

feat(rpc): implement Filecoin.ChainTipSetWeight #4192

merged 6 commits into from
Apr 15, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Apr 15, 2024 •
edited
Loading

Summary of changes

Part of #4185

Changes introduced in this pull request:

  • implement Filecoin.ChainTipSetWeight RPC method with tests
➜  calibnet forest-tool api compare ~/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-04-15_height_1528050.forest.car.zst --filter ChainT
| RPC Method                      | Forest | Lotus |
|---------------------------------|--------|-------|
| Filecoin.ChainTipSetWeight (20) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4193

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 changed the title [WIP] feat(rpc): implement Filecoin.ChainTipSetWeight feat(rpc): implement Filecoin.ChainTipSetWeight Apr 15, 2024
@hanabi1224 hanabi1224 marked this pull request as ready for review April 15, 2024 09:54
@hanabi1224 hanabi1224 requested a review from a team as a code owner April 15, 2024 09:54
@hanabi1224 hanabi1224 requested review from lemmih and aatifsyed and removed request for a team April 15, 2024 09:54
lemmih
lemmih requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the new interface rather than ApiInfo.

src/tool/subcommands/api_cmd.rs Outdated
Comment on lines 604 to 606
tests.push(RpcTest::identity(ApiInfo::chain_tipset_weight_req(
tipset.key().into(),
)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the new API that calls ChainTipSetWeight::request.

aatifsyed
aatifsyed suggested changes Apr 15, 2024
View reviewed changes
src/rpc_client/chain_ops.rs Outdated Show resolved Hide resolved
src/tool/subcommands/api_cmd.rs Outdated Show resolved Hide resolved
@hanabi1224 @aatifsyed
Apply suggestions from code review
eeeb237 
Co-authored-by: Aatif Syed <38045910+aatifsyed@users.noreply.github.com>
@aatifsyed aatifsyed added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 9c8ca3c Apr 15, 2024
27 checks passed
@aatifsyed aatifsyed deleted the hm/rpc-chain-tipset-weight branch April 15, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@aatifsyed aatifsyed aatifsyed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChainTipSetWeight
3 participants
@hanabi1224 @lemmih @aatifsyed