Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document RPC implementation status #4129

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Document RPC implementation status #4129

merged 6 commits into from
Apr 17, 2024

Conversation

ansermino
Copy link
Member

@ansermino ansermino commented Apr 1, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Add basic jsonrpc page to user docs, point to GH project for status

Reference issue to close (if applicable)

Closes

Other information and links

Please review the the status of the implemented methods.

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@aatifsyed
Copy link
Contributor

nonblocking: we should automate this as part of #4032 by using the openrpc snapshot

@aatifsyed aatifsyed mentioned this pull request Apr 12, 2024
Open
14 tasks
@ansermino ansermino marked this pull request as ready for review April 16, 2024 11:44
@ansermino ansermino requested a review from a team as a code owner April 16, 2024 11:44
@ansermino ansermino requested review from lemmih and LesnyRumcajs and removed request for a team April 16, 2024 11:44
@ansermino
Copy link
Member Author

ansermino commented Apr 16, 2024 •
edited
Loading

Screenshot 2024-04-16 at 7 45 26 AM

LesnyRumcajs
LesnyRumcajs approved these changes Apr 16, 2024
View reviewed changes
documentation/src/jsonrpc.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add it to the README for discoverability?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I would like to make some bigger changes to the readme. Opened this as a starting point: #4219

LesnyRumcajs
LesnyRumcajs approved these changes Apr 16, 2024
View reviewed changes
documentation/src/jsonrpc.md Outdated Show resolved Hide resolved
ansermino and others added 2 commits April 16, 2024 11:07
@ansermino @LesnyRumcajs
Stylize slack channel
0e16034 
Co-authored-by: Hubert <hubert@chainsafe.io>
@ansermino
Remove unused css
7972f08
@lemmih lemmih added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 78ca2e0 Apr 17, 2024
27 checks passed
@lemmih lemmih deleted the ansermino/rpc-docs branch April 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ansermino @aatifsyed @lemmih @LesnyRumcajs