refactor: remove duplicate JsonRpcError and Request objects #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatifsyed
requested review from
lemmih and
hanabi1224
and removed request for
a team
aatifsyed
force-pushed
the
aatifsyed/refactor-rpc-error
branch
from
8ae1348
to
bda8bb5
Compare
aatifsyed
force-pushed
the
aatifsyed/refactor-rpc-error
branch
3 times, most recently
from
27cbe03
to
b1fd58a
Compare
|
No green checkmark => no review. |
aatifsyed
force-pushed
the
aatifsyed/refactor-rpc-error
branch
from
b1fd58a
to
05ea2b3
Compare
aatifsyed
force-pushed
the
aatifsyed/refactor-rpc-error
branch
2 times, most recently
from
3c05547
to
b5cfc53
Compare
hanabi1224
approved these changes
Mar 22, 2024
lemmih
approved these changes
Mar 22, 2024
| # Compare the http endpoints | ||
| $FOREST_TOOL_PATH api compare "$snapshot" --forest /ip4/127.0.0.1/tcp/8080/http --lotus /ip4/127.0.0.1/tcp/8081/http --n-tipsets 5 | ||
| $FOREST_TOOL_PATH api compare "$snapshot" --forest /ip4/127.0.0.1/tcp/8080/http --lotus /ip4/127.0.0.1/tcp/8081/http --n-tipsets 5 '--filter=!Filecoin.StateWaitMsg' |
There was a problem hiding this comment.
We probably want to filter out all the flaky tests.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
crate::rpc::error::JsonRpcErrorpubliccrate::rpc_client::JsonRpcErrorin favour of the abovecrate::rpc_client::JsonRpcResponsein favour ofjsonrpsee::types::ResponseRisks:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist