-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove filops snapshot provider and fix ci #3878
Conversation
@@ -36,7 +36,6 @@ use crate::cli_shared::snapshot::parse::ParsedFilename; | |||
pub enum TrustedVendor { | |||
#[default] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeps TrustedVendor
to allow new snapshot providers in the future
afe534b
to
f6b6b9e
Compare
@hanabi1224 shall we delete this test now? Ideally, we'd have no mentions of FilOps anymore (except for the bootstrap nodes). Or at least add a comment, so that future engineers don't have to do any archaeology to understand what this is about. |
@LesnyRumcajs Removed. Please re-approve |
Summary of changes
Filops snapshot service has been shut down, update the code and CI accordingly.
https://github.com/ChainSafe/forest/actions/runs/7551462787/job/20562704877?pr=3873#step:6:50
Changes introduced in this pull request:
Filops
fromTrustedVendor
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist