Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: StateWaitMsg RPC API #3783

Merged
merged 15 commits into from
Jan 2, 2024
Merged

fix: StateWaitMsg RPC API #3783

merged 15 commits into from
Jan 2, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Dec 4, 2023 •
edited
Loading

Summary of changes

As part of #3639

Note: return_dec field is ignored in api compare tests, see #3801 (comment)

Changes introduced in this pull request:

  • Fix Filecoin.StateWaitMsg RPC API
  • Restore api compare tests
  • Fix Receipt deserialization logic
     Running `target/debug/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2023-12-08_height_1156570.forest.car.zst --filter StateWait -n 200`
| RPC Method                  | Forest | Lotus |
|-----------------------------|--------|-------|
| Filecoin.StateWaitMsg (469) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 mentioned this pull request Dec 4, 2023
Open
@hanabi1224 hanabi1224 marked this pull request as ready for review December 4, 2023 09:59
@hanabi1224 hanabi1224 requested a review from a team as a code owner December 4, 2023 09:59
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and aatifsyed and removed request for a team December 4, 2023 09:59
@lemmih
Copy link
Contributor

lemmih commented Dec 4, 2023

Hmm, we should wait with merging this PR until #3784 is addressed.

@hanabi1224 hanabi1224 marked this pull request as draft December 5, 2023 14:57
@hanabi1224 hanabi1224 mentioned this pull request Dec 6, 2023
Merged
4 tasks
@hanabi1224 hanabi1224 marked this pull request as ready for review December 8, 2023 10:46
LesnyRumcajs
LesnyRumcajs approved these changes Dec 11, 2023
View reviewed changes
src/chain/store/chain_store.rs Outdated
db: &DB,
block_header: &BlockHeader,
i: usize,
) -> Result<Option<Receipt>, Error>
where
DB: Blockstore,
{
// Try Receipt_v2 first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the logic for containing this should be in the chain_store. Seems more like a shim thingy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

src/message/chain_message.rs
@@ -32,6 +32,10 @@ impl ChainMessage {
ChainMessage::Signed(msg) => msg.cid(),
}
}

pub fn equal_call(&self, other: &Self) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some docs? I have no idea what it does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@hanabi1224
Copy link
Contributor Author

@LesnyRumcajs Resolved a merge conflict in Cargo.lock, please approve again, thanks!

@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 01da2af Jan 2, 2024
27 checks passed
@hanabi1224 hanabi1224 deleted the hm/fix-state-wait-msg-api branch January 2, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@aatifsyed aatifsyed Awaiting requested review from aatifsyed aatifsyed is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @lemmih @LesnyRumcajs