-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duration to snapshot compute-state json output #3748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmattic
requested review from
hanabi1224 and
LesnyRumcajs
and removed request for
a team
November 29, 2023 10:40
Could you please add a sample output? |
Done. |
lemmih
approved these changes
Nov 29, 2023
@elmattic Could you add a changelog entry for this? |
LesnyRumcajs
approved these changes
Nov 29, 2023
lemmih
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Timings are expressed in nanoseconds. You should see results of the same magnitude as Lotus, for example, when the following commands are used:
lotus state compute-state --json --vm-height <height>
forest-tool snapshot compute-state --epoch <height> --json <snapshot>
Only fvm4 is supported at the moment because of #3524.
Sample output
forest-tool snapshot compute-state --epoch 1131010 --json forest_snapshot_calibnet_2023-11-29_height_1131010.forest.car.zst | jq > compute-state.log
compute-state.log
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist