feat: add filtering and early exit to api compare command
#3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmih
requested review from
ruseinov and
aatifsyed
and removed request for
a team
ruseinov
reviewed
Nov 3, 2023
| let (forest_status, lotus_status) = test.run(&forest, &lotus).await; | ||
| results | ||
| .entry((test.request.method_name, forest_status, lotus_status)) | ||
| .and_modify(|v| *v += 1) | ||
| .or_insert(1u32); | ||
| if (forest_status != EndpointStatus::Valid || lotus_status != EndpointStatus::Valid) |
There was a problem hiding this comment.
nit: could do something like vec![statuses].contains(lotus_status).
ruseinov
approved these changes
Nov 3, 2023
aatifsyed
approved these changes
Nov 3, 2023
src/tool/subcommands/api_cmd.rs
Outdated
| @@ -28,6 +28,12 @@ pub enum ApiCommands { | |||
| /// Snapshot input paths. Supports `.car`, `.car.zst`, and `.forest.car.zst`. | |||
| #[arg()] | |||
| snapshot_files: Vec<PathBuf>, | |||
| /// Test filter | |||
There was a problem hiding this comment.
Could be more helpful - how do I, the user, use it?
There was a problem hiding this comment.
Described the flag in more detail.
| filter: String, | ||
| /// Cancel test run on the first failure | ||
| #[arg(long)] | ||
| fail_fast: bool, |
There was a problem hiding this comment.
I'd prefer --no-fail-fast to match cargo test and cargo nextest
There was a problem hiding this comment.
Clap has little support for --no-* flags. Let's punt this for another time.
LesnyRumcajs
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
--filterflag limiting test runs to a subset of RPC methods.--fast-failflag that cancels a test run on the first failure.Reference issue to close (if applicable)
Part of #3641
Other information and links
Change checklist