Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forest-tool command for measuring RPC completeness and compatibility #3616

Merged
merged 57 commits into from
Nov 2, 2023
Merged

feat: forest-tool command for measuring RPC completeness and compatibility #3616

merged 57 commits into from
Nov 2, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Oct 20, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Add forest-tool api compare command for testing API compatibility.
  • Document how to add new RPC methods (and how to debug them).
  • Client-side support for ChainGetMessagesInTipset, StateMinerPower, Discover and Session.

Reference issue to close (if applicable)

Closes #3584

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

aatifsyed
aatifsyed reviewed Oct 24, 2023
View reviewed changes
src/lotus_json/mod.rs Outdated Show resolved Hide resolved
@lemmih
Copy link
Contributor Author

lemmih commented Oct 30, 2023

This PR is quite minimal. Further improvements are tracked here: #3641

@lemmih lemmih marked this pull request as ready for review October 30, 2023 13:22
@lemmih lemmih requested a review from a team as a code owner October 30, 2023 13:22
@lemmih lemmih requested review from hanabi1224 and jdjaustin and removed request for a team October 30, 2023 13:22
@lemmih lemmih added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@lemmih lemmih added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 645a6ef Nov 2, 2023
30 checks passed
@lemmih lemmih deleted the lemmih/rpc-api-compat branch November 2, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdjaustin jdjaustin jdjaustin approved these changes

@aatifsyed aatifsyed aatifsyed approved these changes

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224 hanabi1224 is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPC compatiblity testing
3 participants
@lemmih @jdjaustin @aatifsyed