-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new command for inspecting state-root mismatches #3589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some documentation of this feature in the developer documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you contrive some test cases, or would that be too time-consuming or complex?
I have no idea how to test this. We have tests for pretty-printing diffs but I don't see an easy way of doing end-to-end testing. |
Looks good to me. As a follow-up would be great to have this tool more exposed by means of public-facing docs. |
2. Download a recent snapshot dated _before_ the failing epoch. | ||
3. Import the snapshot into Lotus and sync to HEAD. | ||
4. Export a new snapshot 100 epochs _after_ the failing epoch. | ||
5. Convert the `.car.zst` file to `.forest.car.zst`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness, let's write how to perform this conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
#[arg(long)] | ||
depth: Option<u64>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could document this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Summary of changes
Changes introduced in this pull request:
forest-tool archive diff
replacesforest-cli state diff
.Example output (with Forest modified to use an incorrect base-fee):
Reference issue to close (if applicable)
Closes #3586
Other information and links
There is no testing since there are no convenient ways of triggering state-root mismatches.
Change checklist