-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: forest-tool snapshot compute-state #3430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2023
aatifsyed
requested review from
ruseinov,
jdjaustin and
lemmih
and removed request for
a team
September 5, 2023 11:57
lemmih
reviewed
Sep 5, 2023
lemmih
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally okay. Some FIXMEs and BUGs that I do not understand. And fvm3
structures should not be used directly. Guillaume opened an issue to avoid the fvm3
he used. You could do the same, but I think it would be easier just to use the shims.
aatifsyed
changed the title
feat: forest-tool compute state
feat: forest-tool snapshot compute-state
Sep 6, 2023
lemmih
approved these changes
Sep 7, 2023
ruseinov
approved these changes
Sep 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #3161
Changes
ExecutionEvent
s, with the following bugs:NetworkChain::from_genesis
CB: FnMut(...) -> anyhow::Result<()>
to take aMessageCallbackCtx
Testing
Tested against forest_snapshot_calibnet_2023-06-20_height_664544.car - see below for obtaining reference from lotus.
Adding integration tests is tracked below
Follow-on work