Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitfield/ rle+ impl #296

Merged
merged 4 commits into from
Mar 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ members = [
"ipld/hamt",
"math/bigint",
"tests/serialization_tests",
"utils/rleplus",
]
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ clean:
@cargo clean -p ipld_hamt
@cargo clean -p ipld_amt
@cargo clean -p forest_bigint
@cargo clean -p rleplus
@echo "Done cleaning."

lint: license clean
Expand Down
17 changes: 17 additions & 0 deletions utils/rleplus/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
[package]
name = "rleplus"
version = "0.1.0"
authors = ["dignifiedquire <dignifiedquire@users.noreply.github.com>", "ChainSafe Systems <info@chainsafe.io>"]
edition = "2018"

[dependencies]
bitvec = "0.17.3"
unsigned-varint = "0.3.1"
serde = { version = "1.0", features = ["derive"] }
serde_bytes = "0.11.3"

[dev-dependencies]
rand_xorshift = "0.1.1"
rand = "0.6.5"
encoding = { package = "forest_encoding", path = "../../encoding/" }
hex = "0.4.0"
73 changes: 73 additions & 0 deletions utils/rleplus/src/bitvec_serde.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// Copyright 2020 ChainSafe Systems
// SPDX-License-Identifier: Apache-2.0, MIT

use super::{decode, encode};
use bitvec::prelude::{BitVec, Lsb0};
use serde::{de, Deserialize, Deserializer, Serialize, Serializer};

/// Wrapper for serializing bit vector with RLE+ encoding
pub struct BitVecSer<'a>(pub &'a BitVec<Lsb0, u8>);

/// Wrapper for deserializing bit vector with RLE+ decoding from bytes.
pub struct BitVecDe(pub BitVec<Lsb0, u8>);

impl Serialize for BitVecSer<'_> {
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where
S: Serializer,
{
// This serialize will encode into rle+ before serializing
serde_bytes::serialize(encode(self.0).as_slice(), serializer)
}
}

impl<'de> Deserialize<'de> for BitVecDe {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
// Deserialize will decode using rle+ decompression
let bz: Vec<u8> = serde_bytes::deserialize(deserializer)?;
let compressed = BitVec::from_vec(bz);
Ok(BitVecDe(decode(&compressed).map_err(de::Error::custom)?))
}
}

#[cfg(test)]
mod tests {
use super::*;
use bitvec::bitvec;
use encoding::{from_slice, to_vec};

#[test]
fn serialize_node_symmetric() {
let bit_vec = bitvec![Lsb0, u8; 0, 1, 0, 1, 1, 1, 1, 1, 1];
let cbor_bz = to_vec(&BitVecSer(&bit_vec)).unwrap();
let BitVecDe(deserialized) = from_slice::<BitVecDe>(&cbor_bz).unwrap();
assert_eq!(deserialized.count_ones(), 7);
assert_eq!(deserialized.as_slice(), bit_vec.as_slice());
}

#[test]
// ported test from specs-actors `bitfield_test.go` with added vector
fn bit_vec_unset_vector() {
let mut bv: BitVec<Lsb0, u8> = BitVec::with_capacity(5);
bv.resize(6, false);
bv.set(1, true);
bv.set(2, true);
bv.set(3, true);
bv.set(4, true);
bv.set(5, true);

bv.set(3, false);
assert_ne!(bv.get(3), Some(&true));
assert_eq!(bv.count_ones(), 4);

// Test cbor marshal and unmarshal
let cbor_bz = to_vec(&BitVecSer(&bv)).unwrap();
assert_eq!(&cbor_bz, &[0x43, 0xa8, 0x54, 0x0]);
let BitVecDe(deserialized) = from_slice::<BitVecDe>(&cbor_bz).unwrap();

assert_eq!(deserialized.as_slice(), bv.as_slice());
}
}
Loading