Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scanning blockchain progress bar never hits 100% when using checkpoints #2403

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jan 10, 2023

Summary of changes

Changes introduced in this pull request:

  • Fix an issue that Scanning blockchain progress bar never hit 100% when checkpoints are used during snapshot import, looks confusing

Reference issue to close (if applicable)

Closes #2404

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 changed the title fix: scanning blockchain progress bar when using checkpoints fix: scanning blockchain progress bar never hits 100% when using checkpoints Jan 10, 2023
@hanabi1224 hanabi1224 marked this pull request as ready for review January 10, 2023 12:43
@lemmih
Copy link
Contributor

lemmih commented Jan 10, 2023

And good job putting the cheap check before the expensive check.

@hanabi1224 hanabi1224 merged commit 11532f3 into main Jan 10, 2023
@hanabi1224 hanabi1224 deleted the hl/fix-scanning-progress-bar branch January 10, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect scanning blockchainprogress during snapshot import
3 participants