Global async logging #232
Merged
Global async logging #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
austinabell
reviewed
Feb 19, 2020
forest/src/logger/mod.rs
Outdated
| .filter(None, log::LevelFilter::Trace) | ||
| .build(); | ||
| async_log::Logger::wrap(logger, || 0) | ||
| .start(log::LevelFilter::Trace) |
There was a problem hiding this comment.
Info should probably be default?
Suggested change
| .start(log::LevelFilter::Trace) | |
| .start(log::LevelFilter::Info) |
austinabell
reviewed
Feb 19, 2020
| // SPDX-License-Identifier: Apache-2.0, MIT | ||
|
|
||
| pub(crate) fn setup_logger() { | ||
| let logger = pretty_env_logger::formatted_timed_builder() |
There was a problem hiding this comment.
Also, thoughts on changing the timestamp format
2020-02-18T19:35:07.045
to something like
2020-02-18 19:35:07
Nit, but the timestamp is a lot to look at right now lol. Can change in another PR or something, this may just be me
|
I've good experience with https://crates.io/crates/flexi_logger. There is also https://github.com/filecoin-project/rust-fil-logger which is used for the filecoin proofs stuff that has a flag to create JSON output that is compatible to the one Lotus is using. |
dutterbutter
approved these changes
Feb 19, 2020
Closed
austinabell
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
fine to leave default logging level as trace for now if you want (although annoying to read through trace logs inside libp2p) and opened issue with: #237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links