-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Stable Futures and Network Refactor #209
Conversation
…ecause of dependancies. easy fix, but gotta go home
let peer_id = PeerId::from(net_keypair.public()); | ||
|
||
info!(log, "Local peer id: {:?}", peer_id); | ||
|
||
let transport = build_transport(net_keypair.clone()); | ||
|
||
let mut swarm = { | ||
let be = MyBehaviour::new(log.clone(), &net_keypair); | ||
let be = ForestBehaviour::new(log.clone(), &net_keypair); | ||
Swarm::new(transport, be, peer_id) | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although not changed in this PR, should we avoid unwrapping on Swarm::listen_on
on LN 86 (below).
I don't see why Github does not allow to comment on code unchanged in pr reviews, saw it being requested here as a feature interestingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like yall commented on it last time. And I don’t see how you can handle that kinda error. If you cant even listen_on, we shouldn’t handle that
Summary of changes
Changes introduced in this pull request:
network
crateReference issue to close (if applicable)
Closes
#142
Other information and links