Added Fetch and Load Methods #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added fetch_tipsets method which returns FullTipset either from store or requesting via blocksync (todo) * Added load_fts which retrieves and constructs full tipset if keys exist in key-value store * Added method for returning Unsigned and Signed Messages from key-value store * Added comments
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
austinabell
suggested changes
Jan 29, 2020
Merged
|
As mentioned, will wait for #197 to be merged and include AMT in this PR. |
…to dustin/fetch-tipsets
…to dustin/fetch-tipsets
austinabell
suggested changes
Feb 4, 2020
austinabell
suggested changes
Feb 5, 2020
austinabell
approved these changes
Feb 5, 2020
ec2
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
fetch_tipsetsmethod which returnsFullTipseteither from store or requesting via blocksync (todo)load_ftswhich retrieves and constructs full tipset if keys exist in key-value storeTipSetKeymethod for returning a reference to cid keysReference issue to close (if applicable)
Closes #195
Other information and links
The full completion of #195 is dependent on the AMT/HAMT and blocksync. See comments in
syncer.rsandstore.rsfor more details. Once this PR is reviewed, I can make a separate task based on the above mentioned TODOS.