Fix existing bug with multibase ToCid #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decoding from string to bytes is broken currently because multibase 0.6 is broken. When updating to 0.7 they removed at least lower case base32 so I wrote a test that currently panics because it isn't supported (but just throws a parse error lol) and will either open an issue or add support for other encoding types in multibase and update at a later time.
There is no rush on this because we will be interacting with bytes, but will document now for when it gets to that point.
Edit: The rewrite I'm referencing by the way for ToCid is to just use the TryFrom trait as this is exactly the same as the trait they setup and is more usable: https://doc.rust-lang.org/std/convert/trait.TryFrom.html