Re-use some code from ref-fvm #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
requested review from
ec2,
noot,
connormullett,
elmattic and
lemmih
as code owners
lemmih
reviewed
Mar 24, 2022
Comment on lines
+35
to
+42
| macro_rules! convert_filter_estimate { | ||
| ($from:expr) => { | ||
| FilterEstimate { | ||
| position: $from.position.clone(), | ||
| velocity: $from.velocity.clone(), | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
It was supposed to be more arcane but I gave up (for now). :(
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
- Coverage 44.40% 44.36% -0.05%
==========================================
Files 319 315 -4
Lines 28231 28151 -80
==========================================
- Hits 12537 12488 -49
+ Misses 15694 15663 -31
Continue to review full report at Codecov.
|
lemmih
approved these changes
Mar 24, 2022
elmattic
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
ref-fvmReference issue to close (if applicable)
Closes #1497
Other information and links