Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start the prometheus server before loading snapshots. #1484

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Mar 18, 2022

Summary of changes
Changes introduced in this pull request:

  • Start the prometheus metrics server before loading snapshots. Metrics are useful even before we can connect to the filecoin network.

Reference issue to close (if applicable)

Other information and links

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1484 (f73fa38) into main (8cfdc9b) will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   44.19%   44.29%   +0.10%     
==========================================
  Files         321      323       +2     
  Lines       28373    28414      +41     
==========================================
+ Hits        12539    12586      +47     
+ Misses      15834    15828       -6     
Impacted Files Coverage Δ
forest/src/daemon.rs 6.29% <0.00%> (ø)
forest/src/cli/mod.rs 0.00% <0.00%> (ø)
forest/src/subcommand.rs 0.00% <0.00%> (ø)
forest/src/cli/config_cmd.rs 64.28% <0.00%> (ø)
forest/tests/config_tests.rs 100.00% <0.00%> (ø)
blockchain/chain_sync/src/chain_muxer.rs 1.74% <0.00%> (+0.24%) ⬆️
node/utils/src/lib.rs 76.92% <0.00%> (+7.69%) ⬆️
forest/src/cli/config.rs 100.00% <0.00%> (+100.00%) ⬆️
node/forest_libp2p/src/config.rs 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfdc9b...f73fa38. Read the comment docs.

@lemmih lemmih merged commit cf49ba7 into main Mar 21, 2022
@lemmih lemmih deleted the lemmih/early-prometheus branch March 21, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants