Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use progress bars when downloading headers and scanning the blockchain. #1480

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Mar 16, 2022

Summary of changes
Changes introduced in this pull request:

  • Use progress bars for the three main time-sinks: Importing a snapshot, scanning the imported blockchain, downloading remaining headers from the network.
  • Demote libp2p peer reports from INFO to DEBUG.

Reference issue to close (if applicable)

Other information and links

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1480 (02c1d60) into main (7783ef8) will decrease coverage by 0.01%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main    #1480      +/-   ##
==========================================
- Coverage   44.19%   44.18%   -0.02%     
==========================================
  Files         322      322              
  Lines       28483    28494      +11     
==========================================
+ Hits        12589    12590       +1     
- Misses      15894    15904      +10     
Impacted Files Coverage Δ
blockchain/chain/src/store/index.rs 25.00% <0.00%> (-2.87%) ⬇️
blockchain/chain_sync/src/tipset_syncer.rs 0.00% <0.00%> (ø)
node/forest_libp2p/src/service.rs 0.00% <0.00%> (ø)
utils/net_utils/src/download.rs 46.87% <50.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7783ef8...02c1d60. Read the comment docs.

@lemmih lemmih merged commit 879cb3e into main Mar 16, 2022
@lemmih lemmih deleted the lemmih/more-progress-bars branch March 16, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants