Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the v6 version of the actor's bundle. #1474

Merged
merged 32 commits into from
Mar 18, 2022
Merged

Use the v6 version of the actor's bundle. #1474

merged 32 commits into from
Mar 18, 2022

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Mar 10, 2022

Summary of changes
Changes introduced in this pull request:

  • The actor's WASM bundle has moved to v7 to we need to explicitly ask for v6.
  • Use serde_ipld_dagcbor instead of cs_serde_cbor for all encoding/decoding.

Reference issue to close (if applicable)

Other information and links

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1474 (f78f0af) into main (d52d4f7) will increase coverage by 0.02%.
The diff coverage is 64.18%.

@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   44.16%   44.19%   +0.02%     
==========================================
  Files         322      321       -1     
  Lines       28482    28373     -109     
==========================================
- Hits        12579    12539      -40     
+ Misses      15903    15834      -69     
Impacted Files Coverage Δ
blockchain/blocks/src/header/mod.rs 64.80% <0.00%> (ø)
blockchain/chain_sync/src/chain_muxer.rs 1.49% <ø> (-1.46%) ⬇️
blockchain/chain_sync/src/validation.rs 18.91% <ø> (ø)
blockchain/message_pool/src/msgpool/utils.rs 57.89% <0.00%> (ø)
blockchain/state_manager/src/lib.rs 1.84% <0.00%> (ø)
ipld/car/src/lib.rs 82.75% <ø> (ø)
ipld/cid/src/lib.rs 100.00% <ø> (+15.55%) ⬆️
ipld/cid/tests/serde_tests.rs 100.00% <ø> (ø)
ipld/src/lib.rs 0.00% <0.00%> (-16.67%) ⬇️
ipld/src/selector/walk.rs 28.98% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d4f7...f78f0af. Read the comment docs.

@lemmih lemmih marked this pull request as ready for review March 15, 2022 09:38
blockchain/chain_sync/src/chain_muxer.rs Show resolved Hide resolved
blockchain/chain_sync/src/validation.rs Outdated Show resolved Hide resolved
blockchain/state_manager/src/lib.rs Show resolved Hide resolved
encoding/src/lib.rs Outdated Show resolved Hide resolved
utils/bigint/Cargo.toml Outdated Show resolved Hide resolved
vm/actor_interface/src/lib.rs Show resolved Hide resolved
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock-solid! It's almost 50% fewer files touched than with the original FVM, we're getting there! 😄

@noot noot merged commit 8cfdc9b into main Mar 18, 2022
@noot noot deleted the lemmih/builtin-actors-v6 branch March 18, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants