Show a progressbar when downloading tipset headers. #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloading tipset headers can take anywhere from minutes to hours.
lemmih
requested review from
ec2,
noot,
connormullett,
elmattic and
LesnyRumcajs
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
- Coverage 24.27% 24.26% -0.01%
==========================================
Files 311 311
Lines 23896 23901 +5
==========================================
Hits 5800 5800
- Misses 18096 18101 +5
Continue to review full report at Codecov.
|
LesnyRumcajs
approved these changes
Mar 8, 2022
| @@ -844,10 +844,17 @@ async fn sync_headers_in_reverse<DB: BlockStore + Sync + Send + 'static>( | |||
| parent_tipsets.push(proposed_head.clone()); | |||
| tracker.write().await.set_epoch(current_head.epoch()); | |||
|
|
|||
| use pbr::ProgressBar; | |||
There was a problem hiding this comment.
we use those only once, how about either moving them to the top of the file or fully qualifying method calls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading tipset headers can take anywhere from minutes to hours.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Other information and links