Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1419 - fix signature verification fiasco #1437

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

LesnyRumcajs
Copy link
Member

Summary of changes
Changes introduced in this pull request:

  • Fixed signature verification which was wrongly taking into account network.
  • Extended unit test suite for signature verification.

Reference issue to close (if applicable)

Fixes #1419

Other information and links

filecoin-project/FIPs#301

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review February 17, 2022 10:32
Copy link
Contributor

@q9f q9f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work! Thank you!

@q9f q9f merged commit 6298815 into main Feb 17, 2022
@q9f q9f deleted the 1419-fix-address-comparison branch February 17, 2022 11:16
LesnyRumcajs added a commit that referenced this pull request Feb 17, 2022
LesnyRumcajs added a commit that referenced this pull request Feb 17, 2022
LesnyRumcajs added a commit that referenced this pull request Feb 17, 2022
* fix clippy fiascoes introduced in #1437

* blockchain/sync: demote chain exchange warning to debug message

* blockchain/sync: lint

Co-authored-by: Hubert Bugaj <hubert@chainsafe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignedMessage::new_from_part result in 'Secp signature verification failed' error because of Network value
3 participants