clippy for tests #1436
Merged
clippy for tests #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
changed the title
LesnyRumcajs
force-pushed
the
1430-clippy-for-tests-and-features
branch
from
9e890b2
to
1198d2f
Compare
LesnyRumcajs
force-pushed
the
1430-clippy-for-tests-and-features
branch
from
1198d2f
to
84c468b
Compare
LesnyRumcajs
requested review from
ec2,
noot,
connormullett,
elmattic and
lemmih
as code owners
lemmih
approved these changes
Feb 16, 2022
q9f
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1430
Other
Unfortunately some dependency fiasco makes it hard to add
--all-features. We don't have that many of them so it shouldn't be a big deal.