Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: default to stable toolchain instead of pinned version #1228

Merged
merged 7 commits into from
Sep 30, 2021
Merged

rust: default to stable toolchain instead of pinned version #1228

merged 7 commits into from
Sep 30, 2021

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Sep 27, 2021

Summary of changes
Changes introduced in this pull request:

  • .circleci/config.yml msrv rust version stable
  • rust-toolchain default rust version stable
  • Dockerfile uses 1-buster rust image
  • Dockerfile-ci uses 1-buster rust image

Other information and links
The rust compiler release cycle is a moving target, and we should at least support the latest stable.

Subsequently, we can set up pipelines for beta, to be alerted about changes coming downstream.

@q9f q9f requested a review from a user September 27, 2021 14:09
@q9f q9f mentioned this pull request Sep 28, 2021
20 tasks
@q9f
Copy link
Contributor Author

q9f commented Sep 28, 2021

I added stable build jobs to #1233 so you can see it works with stable both on macos and linux

should merge #1233 first

@q9f q9f marked this pull request as draft September 28, 2021 16:48
@q9f
Copy link
Contributor Author

q9f commented Sep 28, 2021

This needs more work, I'll do it tomorrow.

@q9f q9f marked this pull request as ready for review September 30, 2021 10:33
@@ -241,7 +241,7 @@ jobs:
command: make license
- run:
name: cargo clippy
command: cargo clippy -- -D warnings -A clippy::upper_case_acronyms
command: cargo clippy -- -D warnings -A clippy::upper_case_acronyms -A clippy::needless_collect -A clippy::enum_variant_names -A clippy::needless_borrow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this @ec2 - this makes clippy pass on stable and instead of fixing these warnings in a single PR, I would like to remove these warnings in subsequent PRs, so you can better review the changes, and if needed, easier revert in case something goes south.

@q9f
Copy link
Contributor Author

q9f commented Sep 30, 2021

This should be safe to merge now once CI is green. I will fix these warnings in separate pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants