-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudflare CI/CD #330
Merged
Merged
Cloudflare CI/CD #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
force-pushed
the
continuous-deployment-cloudflare
branch
6 times, most recently
from
November 3, 2023 09:07
9df02dc
to
7807d0e
Compare
LesnyRumcajs
requested review from
lemmih and
hanabi1224
and removed request for
a team
November 3, 2023 09:12
lemmih
approved these changes
Nov 3, 2023
LesnyRumcajs
force-pushed
the
continuous-deployment-cloudflare
branch
from
November 3, 2023 09:18
7807d0e
to
67d7b92
Compare
lemmih
approved these changes
Nov 3, 2023
hanabi1224
reviewed
Nov 3, 2023
- 'cf/prune-latest' | ||
- '.github/workflows/deploy-cf-prune-latest.yml' | ||
push: | ||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also limit the branch?
push:
branches:
- main
path:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we limit it to main
? We want the --dry-check
to run on pushes to branches as well.
hanabi1224
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
--dry-run
, we are at least able to detect something like, e.g., brokenwrangler.toml
.Reference issue to close (if applicable)
Closes
Other information and links