-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAST CALL - READY to add eip155 #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial thoughts as comments
Also guess when adding more namespaces in the PR we might see more clearly where duplications for for certain sections would happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per consensus at last meeting, I've restructured the .md as a folder containing distinct markdown files for CAIPs. I took the liberty of giving a more human-readable name (i.e., "assets" rather than "CAIP-20/21", because I would imagine that some namespaces have to slice these things differently, as happened to me with the polkadot example, where the "addresses.md" file might not require CAIP-2, for example-- this slight decoupling of namespace markdown files from CAIPs allows them to map differently per namespace as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only thing I would change is the name of the files, e.g. eip155/caip10.md
instead of eip155/addresses.md
. Would also be nice to have links to these documents from the eip155/README.md
.
Oh, I see your comment now. I still think |
That last point won me over, caip-2.md it is! 😄 As for readmes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure lgtm, some fixes needed to markdown formatting.
2 approvals, should we 🚢 it, @ligi ? |
* feat: Adds CAIP-122 standard for XRP Ledger. * fix: Add some clarifications and follow the ripple-keypairs implementations for signing and verification * fix: Branch was renamed from master to main * fix: Remove double
Open question:
evm
andeip155
😅