Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to add hedera/readme, /c2, c10, & c19 #16

Merged
merged 7 commits into from
Jan 11, 2023
Merged

to add hedera/readme, /c2, c10, & c19 #16

merged 7 commits into from
Jan 11, 2023

Conversation

bumblefudge
Copy link
Collaborator

@bumblefudge bumblefudge commented Mar 27, 2022

These were really easy to work with and I greatly appreciated the "Rejected Alternatives" section of HIP30! @shemnon, let me know if I made any mistakes in what I added and changed!

My only significant changes:

  • new frontmatter in /readme explaining HIP-30 is definitive
  • reduced largest-potential chainID to 32chars, as per length limits across all CAIP-10s
  • added warning about incomplete ERC20/721 cross-compatibility
  • added myself as co-author of the caip-19 spec, since it required the most research and intervention on my part :D

hedera/caip10.md Outdated
Comment on lines 20 to 25
In CAIP-10 a general account address scheme is defined. The definitions of
Hedera Address do not fit neatly into that specification so an alternate address
format is defined for Hedera. Encoding a three-part Hedera account ID as a
string is done by separating the three parts with `.`s; this future-proofs the
implementation of realms and shards, although in today's usage, effectively all
known addresses still begin with `0.0.`.
Copy link
Collaborator Author

@bumblefudge bumblefudge Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened an issue to track this: ChainAgnostic/CAIPs#103

Copy link

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bumblefudge added 2 commits December 6, 2022 15:55
Signed-off-by: bumblefudge <jcaballero@centre.io>
Signed-off-by: bumblefudge <jcaballero@centre.io>
@bumblefudge bumblefudge added 14-day merge hoping to merge within next 14 days and removed blocked by CAIPs labels Dec 6, 2022
@bumblefudge bumblefudge merged commit 2ec83dc into main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-day merge hoping to merge within next 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants