-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to add hedera/readme, /c2, c10, & c19 #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumblefudge
commented
Mar 27, 2022
hedera/caip10.md
Outdated
Comment on lines
20
to
25
In CAIP-10 a general account address scheme is defined. The definitions of | ||
Hedera Address do not fit neatly into that specification so an alternate address | ||
format is defined for Hedera. Encoding a three-part Hedera account ID as a | ||
string is done by separating the three parts with `.`s; this future-proofs the | ||
implementation of realms and shards, although in today's usage, effectively all | ||
known addresses still begin with `0.0.`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened an issue to track this: ChainAgnostic/CAIPs#103
This was referenced Apr 7, 2022
shemnon
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shemnon
approved these changes
Oct 18, 2022
8 tasks
Signed-off-by: bumblefudge <jcaballero@centre.io>
Signed-off-by: bumblefudge <jcaballero@centre.io>
shemnon
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were really easy to work with and I greatly appreciated the "Rejected Alternatives" section of HIP30! @shemnon, let me know if I made any mistakes in what I added and changed!
My only significant changes: