Use 'eth_sendTransaction' for CAIP-27 example. 'personal_sign' is not… #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… broadcast and therefore a bad example
bumblefudge
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
I totally agree!
In fact, a second PR adding an additional example with personal_sign sent, targeted to wallet:eip155 rather than eip155:1 (or eip155:0 for that matter) might be a useful addition, here and/or in a profile for the namespaces repo, i.e. in the wallet/caip25.md profile 😎
1 review from hassan or two from non-codeowners and we merge
hmalik88
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'personal_sign' is an offchain signing method (more appropriate to the new proposed Wallet namespace) and therefore a bad example for
CAIP-27