Skip to content

Commit

Permalink
vhost: decrease log level for unimplemented requests
Browse files Browse the repository at this point in the history
This patch changes VHOST_USER_SET_VRING_ERR and
VHOST_USER_SET_LOG_FD "not implemented" log levels from
INFO to DEBUG, as implementing these requests is not
mandatory. Having them being displayed at INFO level
may induce some confusion to the end-user.

Fixes: fd29c33 ("vhost: handle unsupported message types in functions")
Cc: stable@dpdk.org

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
  • Loading branch information
mcoquelin committed Feb 9, 2023
1 parent 34924a8 commit 43ccd55
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/vhost/vhost_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,

if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
close(ctx->fds[0]);
VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");

return RTE_VHOST_MSG_RESULT_OK;
}
Expand Down Expand Up @@ -2340,7 +2340,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
return RTE_VHOST_MSG_RESULT_ERR;

close(ctx->fds[0]);
VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");

return RTE_VHOST_MSG_RESULT_OK;
}
Expand Down

0 comments on commit 43ccd55

Please sign in to comment.