AxisAlignedBox and OrientedBoundingBox improvements #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
reviewed
Mar 20, 2023
| @@ -78,4 +78,13 @@ estimateGlobeRectangle(const BoundingVolume& boundingVolume); | |||
| CESIUM3DTILESSELECTION_API const CesiumGeospatial::BoundingRegion* | |||
| getBoundingRegionFromBoundingVolume(const BoundingVolume& boundingVolume); | |||
|
|
|||
| /** | |||
| * @brief Get an oriented bounding box that contains this bounding volume. | |||
There was a problem hiding this comment.
Suggested change
| * @brief Get an oriented bounding box that contains this bounding volume. | |
| * @brief Returns an oriented bounding box that contains the given {@link BoundingVolume}. |
Nitpick, just for consistency with the other documentation in this file.
| @@ -49,8 +50,9 @@ class CESIUMGEOMETRY_API OrientedBoundingBox final { | |||
| } | |||
|
|
|||
| /** | |||
| * @brief Gets the transformation matrix, to rotate and scale the box to the | |||
| * right position and size. | |||
| * @brief Gets he three orthogonal half-axes of the bounding box. | |||
There was a problem hiding this comment.
Suggested change
| * @brief Gets he three orthogonal half-axes of the bounding box. | |
| * @brief Gets the three orthogonal half-axes of the bounding box. |
|
merging now that CI has passed, thanks @kring ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the changelog:
Additions 🎉
getOrientedBoundingBoxFromBoundingVolumeto theCesium3DTilesSelectionnamespace.transformandtoAxisAlignedmethods toOrientedBoundingBox.Fixes 🔧
centerfield ofAxisAlignedBoxto be incorrect.