Release/5.3.0 rc2 #337
Merged
Release/5.3.0 rc2 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [x] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated. --------- Co-authored-by: rakanalh <rakan.alhneiti@gmail.com> Co-authored-by: Maksim Ramanenkau <cbnhrpo@gmail.com>
#297) …is enabled ### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description This PR applies missing staking migrations with some changes in v9 and v11: 1. The migration to v9 has been altered to set the next pallet version only. The remaining parts are not needed because we are already using VoterList and it's in good condition. To change the migration, the source code has been moved from workplace dependencies to the Cere repo. 2. In migration to v11, there is no need to move data from BagsList to VoterList since we are already using VoterList. Instead, BagsList should be removed. 3. Benchmarking and Clippy checks are disabled for the sake of time. 4. Apply migrations to v8, v10, v12, v13. Notes: 1. BagsList has been migrated to VoterList in [v4.1.0](https://github.com/Cerebellum-Network/blockchain-node/compare/v4.0.0..v4.1.0#diff-8979c26ba42edc867488ec32089e6e48df0774444fe9a4726a09d129545060dbR1347) but the migration was not written and executed properly. 2. Staking pallet changes can be reviewed with `diff -r substrate/frame/staking blockchain-node/pallets/staking` or with [kdiff3](https://kdiff3.sourceforge.net/) if one prefers graphical UI. In both cases, you must have [Substrate](https://github.com/paritytech/substrate) locally. 3. To get back to the original staking pallet, [b80f635](b80f635), [5c8fcbd](5c8fcbd), and [1b71aa8](1b71aa8) should be reverted ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> Seems like a useless pallet that nobody uses. Also requires migrations in v1.0.0 which i would rather remove the need for rather than keeping the pallet. ### Types of Changes <!--- What types of changes does your code introduce? --> - [x] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [x] Changelog doc updated. --------- Co-authored-by: Maksim Ramanenkau <cbnhrpo@gmail.com>
### Description Merging PR #305 ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [X] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [X] Change has been tested locally. - [X] Change adds / updates tests. - [ ] Changelog doc updated.
### Description Use the original Staking pallet. See [note #3](#300) ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> Substrate [v1.1.0](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.1.0) upgrade which is required for some OpenGov migrations. ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [x] Changelog doc updated. ### TODO - [x] Update dependencies - [x] Cleanup existing migrations - [x] Include new migrations. --------- Co-authored-by: yahortsaryk <egortsaryk@gmail.com>
### Description 1. Use the `stable` channel since `nightly` doesn't work for Clippy. 2. Keep `nightly` for `rustfmt` since it uses unstable features. 3. Execute `cargo +nightly-2024-03-12 fmt` ### Types of Changes <!--- What types of changes does your code introduce? --> - [x] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
### Description Enabling the [OpenGov](https://wiki.polkadot.network/docs/learn-polkadot-opengov). <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) - [x] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [x] Change adds / updates tests. - [x] Changelog doc updated.
### Description <!-- Describe what change this PR is implementing --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been tested locally. - [ ] Change adds / updates tests. - [ ] Changelog doc updated.
…330) ## Description <!-- Describe what change this PR is implementing --> ## Types of Changes Please select the branch type you are merging and fill in the relevant template. <!--- Check the following box with an x if the following applies: --> - [ ] Hotfix - [ ] Release - [x] Fix or Feature ## Fix or Feature <!--- Check the following box with an x if the following applies: --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist for Fix or Feature <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [ ] Change adds / updates tests if applicable. - [ ] Changelog doc updated. ## Checklist for Hotfix <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [ ] Changelog has been updated. - [ ] Crate version has been updated. - [ ] Spec version has been updated. - [ ] Transaction version has been updated if required. - [ ] Pull Request to `dev` has been created. - [ ] Pull Request to `staging` has been created. ## Checklist for Release <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been deployed to Devnet. - [ ] Change has been tested in Devnet. - [ ] Change has been deployed to Qanet. - [ ] Change has been tested in Qanet. - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [ ] Changelog has been updated. - [ ] Crate version has been updated. - [ ] Spec version has been updated. - [ ] Transaction version has been updated if required.
## Description Extended Cluster pallet by Cluster Configuration parameters ## Types of Changes Please select the branch type you are merging and fill in the relevant template. <!--- Check the following box with an x if the following applies: --> - [ ] Hotfix - [ ] Release - [X] Fix or Feature ## Fix or Feature <!--- Check the following box with an x if the following applies: --> ### Types of Changes <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) ### Migrations and Hooks <!--- Check the following box with an x if the following applies: --> - [X] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` ### Checklist for Fix or Feature <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [X] Change has been tested locally. - [X] Change adds / updates tests if applicable. - [X] Changelog doc updated. ## Checklist for Hotfix <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [ ] Changelog has been updated. - [ ] Crate version has been updated. - [ ] Spec version has been updated. - [ ] Transaction version has been updated if required. - [ ] Pull Request to `dev` has been created. - [ ] Pull Request to `staging` has been created. ## Checklist for Release <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been deployed to Devnet. - [ ] Change has been tested in Devnet. - [ ] Change has been deployed to Qanet. - [ ] Change has been tested in Qanet. - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [X] Changelog has been updated. - [ ] Crate version has been updated. - [X] Spec version has been updated. - [X] Transaction version has been updated if required.
<!-- Describe what change this PR is implementing --> Companion for [Hotfix #333](#333) <!--- Check the following box with an x if the following applies: --> - [x] Hotfix - [ ] Release - [ ] Fix or Feature <!--- Check the following box with an x if the following applies: --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [ ] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [x] Change adds / updates tests if applicable. - [x] Changelog doc updated. <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [x] Changelog has been updated. - [x] Crate version has been updated. - [x] Spec version has been updated. - [ ] Transaction version has been updated if required. - [x] Pull Request to `dev` has been created. - [ ] Pull Request to `staging` has been created. <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [ ] Change has been deployed to Devnet. - [ ] Change has been tested in Devnet. - [ ] Change has been deployed to Qanet. - [ ] Change has been tested in Qanet. - [ ] Change has been deployed to Testnet. - [ ] Change has been tested in Testnet. - [ ] Changelog has been updated. - [ ] Crate version has been updated. - [ ] Spec version has been updated. - [ ] Transaction version has been updated if required.
yahortsaryk
approved these changes
May 16, 2024
MRamanenkau
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
Fix or Feature
Types of Changes
Migrations and Hooks
on_initializeon_finalizeChecklist for Fix or Feature
Checklist for Hotfix
devhas been created.staginghas been created.Checklist for Release