Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of the substrate 1.1.0 and OpenGov to pass the try-runtime check #330

Merged
merged 2 commits into from
May 8, 2024
Merged

Fix of the substrate 1.1.0 and OpenGov to pass the try-runtime check #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f39938
fix: setting MaxHolds to non-zero value and adding a v1 migration for…
yahortsaryk May 7, 2024
364687c
fix: runtime version bump
yahortsaryk May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions runtime/cere-dev/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
// and set impl_version to 0. If only runtime
// implementation changes and behavior does not, then leave spec_version as
// is and increment impl_version.
spec_version: 53000,
spec_version: 53001,
impl_version: 0,
apis: RUNTIME_API_VERSIONS,
transaction_version: 16,
Expand Down Expand Up @@ -430,6 +430,7 @@ parameter_types! {
// This number may need to be adjusted in the future if this assumption no longer holds true.
pub const MaxLocks: u32 = 50;
pub const MaxReserves: u32 = 50;
pub const MaxHolds: u32 = 50;
}

impl pallet_balances::Config for Runtime {
Expand All @@ -445,7 +446,7 @@ impl pallet_balances::Config for Runtime {
type FreezeIdentifier = ();
type MaxFreezes = ();
type RuntimeHoldReason = RuntimeHoldReason;
type MaxHolds = ConstU32<0>;
type MaxHolds = MaxHolds;
}

parameter_types! {
Expand Down Expand Up @@ -1321,6 +1322,7 @@ pub mod migrations {
/// Unreleased migrations. Add new ones here:
pub type Unreleased = (
pallet_contracts::migration::Migration<Runtime>,
pallet_referenda::migration::v1::MigrateV0ToV1<Runtime>,
// Gov v1 storage migrations
// https://github.com/paritytech/polkadot/issues/6749
pallet_elections_phragmen::migrations::unlock_and_unreserve_all_funds::UnlockAndUnreserveAllFunds<UnlockConfig>,
Expand Down
6 changes: 4 additions & 2 deletions runtime/cere/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
// and set impl_version to 0. If only runtime
// implementation changes and behavior does not, then leave spec_version as
// is and increment impl_version.
spec_version: 53000,
spec_version: 53001,
impl_version: 0,
apis: RUNTIME_API_VERSIONS,
transaction_version: 16,
Expand Down Expand Up @@ -424,6 +424,7 @@ parameter_types! {
// This number may need to be adjusted in the future if this assumption no longer holds true.
pub const MaxLocks: u32 = 50;
pub const MaxReserves: u32 = 50;
pub const MaxHolds: u32 = 50;
}

impl pallet_balances::Config for Runtime {
Expand All @@ -439,7 +440,7 @@ impl pallet_balances::Config for Runtime {
type FreezeIdentifier = ();
type MaxFreezes = ();
type RuntimeHoldReason = RuntimeHoldReason;
type MaxHolds = ConstU32<0>;
type MaxHolds = MaxHolds;
}

parameter_types! {
Expand Down Expand Up @@ -1323,6 +1324,7 @@ pub mod migrations {
/// Unreleased migrations. Add new ones here:
pub type Unreleased = (
pallet_contracts::migration::Migration<Runtime>,
pallet_referenda::migration::v1::MigrateV0ToV1<Runtime>,
// Gov v1 storage migrations
// https://github.com/paritytech/polkadot/issues/6749
pallet_elections_phragmen::migrations::unlock_and_unreserve_all_funds::UnlockAndUnreserveAllFunds<UnlockConfig>,
Expand Down
Loading