-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bucket remove #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aie0
suggested changes
Feb 13, 2024
…igration compilation
MRamanenkau
force-pushed
the
feature/bucket-remove
branch
from
February 16, 2024 14:50
a256631
to
7963fec
Compare
MRamanenkau
force-pushed
the
feature/bucket-remove
branch
from
February 16, 2024 16:02
7963fec
to
f3b08a1
Compare
rakanalh
suggested changes
Feb 19, 2024
rakanalh
reviewed
Feb 19, 2024
aie0
suggested changes
Feb 19, 2024
rakanalh
approved these changes
Feb 19, 2024
aie0
approved these changes
Feb 19, 2024
aie0
pushed a commit
that referenced
this pull request
Feb 20, 2024
<!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [x] Change adds / updates tests. - [x] Changelog doc updated. --------- Co-authored-by: rakanalh <rakan.alhneiti@gmail.com>
aie0
pushed a commit
that referenced
this pull request
Feb 20, 2024
<!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [x] Change adds / updates tests. - [x] Changelog doc updated. --------- Co-authored-by: rakanalh <rakan.alhneiti@gmail.com>
aie0
pushed a commit
that referenced
this pull request
Feb 21, 2024
<!-- Describe what change this PR is implementing --> <!--- What types of changes does your code introduce? --> - [ ] Tech Debt (Code improvements) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Dependency upgrade (A change in substrate or any 3rd party crate version) <!--- Check the following box with an x if the following applies: --> - [x] This change requires a runtime migration. - [ ] Modifies `on_initialize` - [ ] Modifies `on_finalize` <!--- All boxes need to be checked. Follow this checklist before requiring PR review --> - [x] Change has been tested locally. - [x] Change adds / updates tests. - [x] Changelog doc updated. --------- Co-authored-by: rakanalh <rakan.alhneiti@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Migrations and Hooks
on_initialize
on_finalize
Checklist