Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bucket remove #268

Merged
merged 20 commits into from
Feb 20, 2024
Merged

Feature/bucket remove #268

merged 20 commits into from
Feb 20, 2024

Conversation

MRamanenkau
Copy link
Contributor

@MRamanenkau MRamanenkau commented Feb 13, 2024

Description

Types of Changes

  • Tech Debt (Code improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

  • This change requires a runtime migration.
  • Modifies on_initialize
  • Modifies on_finalize

Checklist

  • Change has been tested locally.
  • Change adds / updates tests.
  • Changelog doc updated.

pallets/ddc-customers/Cargo.toml Show resolved Hide resolved
pallets/ddc-customers/src/lib.rs Outdated Show resolved Hide resolved
pallets/ddc-customers/src/lib.rs Outdated Show resolved Hide resolved
pallets/ddc-customers/src/lib.rs Show resolved Hide resolved
@MRamanenkau MRamanenkau force-pushed the feature/bucket-remove branch from a256631 to 7963fec Compare February 16, 2024 14:50
@MRamanenkau MRamanenkau force-pushed the feature/bucket-remove branch from 7963fec to f3b08a1 Compare February 16, 2024 16:02
@MRamanenkau MRamanenkau marked this pull request as ready for review February 18, 2024 12:28
@auto-assign auto-assign bot requested a review from aie0 February 18, 2024 12:28
pallets/ddc-customers/src/lib.rs Outdated Show resolved Hide resolved
pallets/ddc-customers/src/lib.rs Outdated Show resolved Hide resolved
runtime/cere/src/lib.rs Show resolved Hide resolved
runtime/cere/src/lib.rs Outdated Show resolved Hide resolved
pallets/ddc-customers/src/lib.rs Outdated Show resolved Hide resolved
pallets/ddc-customers/src/lib.rs Outdated Show resolved Hide resolved
@MRamanenkau MRamanenkau merged commit 8c732e3 into dev Feb 20, 2024
5 checks passed
@MRamanenkau MRamanenkau deleted the feature/bucket-remove branch February 20, 2024 08:22
aie0 pushed a commit that referenced this pull request Feb 20, 2024
<!-- Describe what change this PR is implementing -->

<!--- What types of changes does your code introduce? -->
- [ ] Tech Debt (Code improvements)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Dependency upgrade (A change in substrate or any 3rd party crate
version)

<!--- Check the following box with an x if the following applies: -->
- [x] This change requires a runtime migration.
- [ ] Modifies `on_initialize`
- [ ] Modifies `on_finalize`

<!--- All boxes need to be checked. Follow this checklist before
requiring PR review -->
- [x] Change has been tested locally.
- [x] Change adds / updates tests.
- [x] Changelog doc updated.

---------

Co-authored-by: rakanalh <rakan.alhneiti@gmail.com>
aie0 pushed a commit that referenced this pull request Feb 20, 2024
<!-- Describe what change this PR is implementing -->

<!--- What types of changes does your code introduce? -->
- [ ] Tech Debt (Code improvements)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Dependency upgrade (A change in substrate or any 3rd party crate
version)

<!--- Check the following box with an x if the following applies: -->
- [x] This change requires a runtime migration.
- [ ] Modifies `on_initialize`
- [ ] Modifies `on_finalize`

<!--- All boxes need to be checked. Follow this checklist before
requiring PR review -->
- [x] Change has been tested locally.
- [x] Change adds / updates tests.
- [x] Changelog doc updated.

---------

Co-authored-by: rakanalh <rakan.alhneiti@gmail.com>
aie0 pushed a commit that referenced this pull request Feb 21, 2024
<!-- Describe what change this PR is implementing -->

<!--- What types of changes does your code introduce? -->
- [ ] Tech Debt (Code improvements)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Dependency upgrade (A change in substrate or any 3rd party crate
version)

<!--- Check the following box with an x if the following applies: -->
- [x] This change requires a runtime migration.
- [ ] Modifies `on_initialize`
- [ ] Modifies `on_finalize`

<!--- All boxes need to be checked. Follow this checklist before
requiring PR review -->
- [x] Change has been tested locally.
- [x] Change adds / updates tests.
- [x] Changelog doc updated.

---------

Co-authored-by: rakanalh <rakan.alhneiti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants