Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis config for pallet-ddc-clusters #153

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

khssnv
Copy link
Member

@khssnv khssnv commented Nov 23, 2023

  • GenesisConfig implementation for pallet-ddc-clusters.
  • It skips add_node with checks and directly writes to the storage because currently cluster authorization smart contract is mandatory, but can't be set in in a genesis state (pallet-contracts does not implement GenesisConfig). Future implementation may make the extension contract optional and use add_node to check if the user set ddc-staking and ddc-nodes genesis consistently.

@khssnv khssnv marked this pull request as draft November 23, 2023 05:56
@khssnv khssnv force-pushed the feature/ddc-clusters-genesis branch 2 times, most recently from 7b8c355 to b7c44ef Compare November 23, 2023 06:47
@khssnv khssnv marked this pull request as ready for review November 23, 2023 06:49
@khssnv khssnv force-pushed the feature/ddc-clusters-genesis branch from b7c44ef to 2540a9d Compare November 23, 2023 07:02
@khssnv khssnv force-pushed the feature/ddc-clusters-genesis branch from 2540a9d to 2d087e0 Compare November 24, 2023 05:04
rakanalh
rakanalh previously approved these changes Nov 27, 2023
Copy link
Contributor

@Raid5594 Raid5594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the genesis config might be useful for mock & tests, but what about benchmarks?

@rakanalh rakanalh merged commit f276b7f into dev Nov 27, 2023
3 checks passed
@rakanalh rakanalh deleted the feature/ddc-clusters-genesis branch November 27, 2023 10:01
yahortsaryk pushed a commit that referenced this pull request Dec 8, 2023
aie0 pushed a commit that referenced this pull request Dec 11, 2023
Backporting the following PRs from the `dev` branch:
- [#184](#184)
- [#169](#169)
- [#175](#175)
- [#177](#177)
- [#159](#159)
- [#162](#162)
- [#153](#153)
- [#163](#163)
- [#143](#143)
- [#150](#150)
- [#149](#149)

---------

Co-authored-by: Raid5594 <52794079+Raid5594@users.noreply.github.com>
Co-authored-by: Alisher A. Khassanov <a.khssnv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants