Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated schema, template to support netmask in libvirt network provisioning #950

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

samvarankashyap
Copy link
Contributor

@samvarankashyap samvarankashyap commented Feb 18, 2019

$subject
fixes #939

Test template output:

<network ipv6='yes'>
  <name>linchpin-centos74</name>
  />
  <forward mode="nat"/>
  <domain name="linchpin.net" localOnly="yes"/>
  <ip address="192.168.74.100"  netmask="255.255.255.0" >
    <dhcp>
      <range start="192.168.74.101" end="192.168.74.112"/>
    </dhcp>
  </ip>
</network>

@samvarankashyap
Copy link
Contributor Author

@p3ck Will try to add test to this PR. I am not sure whether it would pass though.

@adl-bot
Copy link

adl-bot commented Feb 21, 2019

@samvarankashyap
Copy link
Contributor Author

[merge]

@adl-bot adl-bot merged commit efae5b6 into CentOS-PaaS-SIG:develop Feb 22, 2019
@14rcole 14rcole added this to the v1.7.2 milestone Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ability to configure subnet mask for libvirt network interface
4 participants