Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aws_ec2_vpc_net role in Linchpin #907

Merged
merged 9 commits into from
Jan 23, 2019

Conversation

samvarankashyap
Copy link
Contributor

@samvarankashyap samvarankashyap commented Jan 16, 2019

$subject
example:

aws-ec2-vpc-net:
  topology:
    topology_name: ec2vpc
    resource_groups:
      - resource_group_name: "awsvpc"
        resource_group_type: "aws"
        resource_definitions:
          - name: demodayvpc
            role: aws_ec2_vpc_net
            region: us-east-1
            cidr_block: 10.10.0.0/16
            tags:
              module: aws_ec2_vpc_net
              this: works
            tenancy: dedicated
        credentials:
          filename: aws.yaml
          profile: default

fixes: #827
should be merged after #894

@adl-bot
Copy link

adl-bot commented Jan 16, 2019

@adl-bot
Copy link

adl-bot commented Jan 16, 2019

@adl-bot
Copy link

adl-bot commented Jan 16, 2019

@samvarankashyap
Copy link
Contributor Author

[test]

1 similar comment
@samvarankashyap
Copy link
Contributor Author

[test]

@samvarankashyap
Copy link
Contributor Author

rebased to fix conflicts with develop branch

@adl-bot
Copy link

adl-bot commented Jan 21, 2019

@samvarankashyap
Copy link
Contributor Author

@14rcole @p3ck : Needs approval

@samvarankashyap samvarankashyap requested a review from p3ck January 21, 2019 14:59
@adl-bot
Copy link

adl-bot commented Jan 21, 2019

@adl-bot
Copy link

adl-bot commented Jan 22, 2019

@p3ck
Copy link
Contributor

p3ck commented Jan 22, 2019

the unit tests are failing because we don't have gcc. :-(

We will need to add gcc to the container

@samvarankashyap
Copy link
Contributor Author

samvarankashyap commented Jan 22, 2019

@p3ck How come it worked before then ??

@samvarankashyap
Copy link
Contributor Author

@p3ck
Copy link
Contributor

p3ck commented Jan 22, 2019

The unit tests are executed via HDSL in the ansible-executor. We may have to actually provision a resource to run it.

I don't know why it worked before. Did you add/update any Requires in the latest patch?

@samvarankashyap
Copy link
Contributor Author

@p3ck : I added boto3 in requirements.txt. However , That's in previous commits which worked fine for unit tests.

@samvarankashyap
Copy link
Contributor Author

[test]

@adl-bot
Copy link

adl-bot commented Jan 23, 2019

@samvarankashyap
Copy link
Contributor Author

[test]

@adl-bot
Copy link

adl-bot commented Jan 23, 2019

@samvarankashyap
Copy link
Contributor Author

[merge]

@adl-bot adl-bot merged commit d319f94 into CentOS-PaaS-SIG:develop Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS: Networking: Add support for ec2_vpc ansible module in linchpin topologies
4 participants